Kyle

I checked, It's just a problem with the test. The feature works properly with the example given in the new documentation.

Test fixed. It was a naming problem: RuleOneInThirdRuleSet instead of RuleOneInFifthRuleSet as it refers to the set3.xml.

By marking an argument as mandatory, the interface expect you to use it. If the interface is properly done, and does not allow to omit `$bar` and `$baz`, it means...

Yep indeed. Relevant.

I see the point, but here using `ARRAY_FILTER_USE_KEY` would be way better. While it's not always immediately and easily fixable, having a not used parameter should warn a flag. First:...

> you implement an interface that you have no control over That's the point. As I said, if you use nothing of an interface, you should probably not use this...

Hello 👋 properly formatted statements in PHP should end with `;` which mean using `` instead of `` and indeed this syntax would properly work with PHPMD. It's sure we...

> and not just error out completely and give an unhelpful message As I said, we should warn with `"Always end statement with a semi-colon"`, that's why I sorted this...

Hello @rafael-neris thanks for investigating this. I prepared a branch you can clone with a test that reproduce this issue: https://github.com/pdepend/pdepend/tree/fix/optional-semi-colon-before-php-end-tag After installing dependencies locally with `composer update --ignore-platform-reqs` you...

Hello @rafael-neris, I started a fix on #553 (still the same branch: [fix/optional-semi-colon-before-php-end-tag](https://github.com/pdepend/pdepend/tree/fix/optional-semi-colon-before-php-end-tag)) and it might be more difficult than I expected (it broke other tests) but you can still...