Kyle

Results 289 comments of Kyle

I confirm this happens in PHPMD 2.7.0 and I confirm both `@SuppressWarnings(unused)` and `@SuppressWarnings(PHPMD.UnusedPrivateField)` correctly suppress the warning it put on the class doc block but not at property level.

The correct way to fix it in my opinion would be to handle it in PDepend: https://github.com/pdepend/pdepend/blob/master/src/main/php/PDepend/Input/ExcludePathFilter.php#L91 The `ExcludePathFilter::accept()` method determines if a given file matches a given pattern. So...

Hello, regarding our workload, core team members focus their availability on bug fixes and this remains low priority in our pipe. But if you feel like you can do a...

Hello, thanks for your report. I guess this is a reduced version and the real code contains 2 methods right? Else I don't see how `fromHtml()` can end to be...

Sure PHPMD should handle it, but as for my personal opinion, having an output (yield) and an assignation ($result =) in the same line of code is a code smell....

I agree the violation could be ignored when it's in `__construct()` rather it's promoted or not actually.

I started to work on this but the code above does not trigger a violation, it only triggers if the arguments has a default value such as `bool $someBoolProp =...

> And having a property with a default value is not a bad practice or a code smell, right? That's the point of the Cat `isDog` vs. `isFluffy` example above....

> when an entity has a boolean property that needs a default value Please show a real example of this "need". I am actually tempted to believe that we have...