Kyle

Results 289 comments of Kyle

Indeed, despite this one is very old the `ExcessiveClassLength` is not relevant today. The default value of 1000 lines is incredibly high probably because comments and blank lines are taken...

So it also requires us to extends **ruleset_xml_schema.xsd** and publish our own xsd file for PHPMD ruleset format.

Thanks, yes, XML validation errors would be great! I add this to 2.9 todo list. PRs are welcome.

In fact this is copying value inside the variable and it's not needed. I know it's not your fault. It's the way the function is designed. But maybe it's the...

Yes, this allows either to `catch(\RuntimeException $exception)` (all runtime exception from anywhere), or `catch(\PHPMD\Exception\Exception $exception)` (any kind of exception from PHPMD) or `catch(\PHPMD\Exception\RuntimeException $exception)` (the specific kind from PHPMD).

The same happens for ShortVariable too: https://github.com/phpmd/phpmd/issues/337#issuecomment-208363809

Yes, good idea, `fileName` to respect the camelCase used in other keys. But this way, we avoid having a new option to document. :)

What about `baseName` referring https://www.php.net/manual/en/function.basename.php

Oups, my mistake, indeed baseName was not what we're looking for.

It's about relative path (implicitly relative to current directory [getcwd](https://www.php.net/manual/en/function.getcwd.php) which is where you run the `phpmd` command. And the Psalm solution will still return an absolute path for paths...