Kevin Yeh

Results 6 comments of Kevin Yeh

nice, just one comment; looks great otherwise.

👋 Revisiting this after discussion with @munusshih for GSoC. I believe @dhowe's comment shows how you can get close to the functionality of CSS line-height by using centered vertical text...

Hi! That particular dependency should be included with dropwizard. Can you confirm your build settings for the war file? I don't know much about wildfly, but I'm taking a look...

hey @billoneil, sorry for the delayed response — I missed this until now. The TcpWriter should [recreate the connection after closing](https://github.com/kickstarter/dropwizard-influxdb-reporter/blob/master/src/main/java/com/kickstarter/dropwizard/metrics/influxdb/io/InfluxDbTcpWriter.java#L31-L34), and the HTTP writer should do the same (but...

hey @tosheer! could you add this compiler arg to your `pom.xml` and rebuild/re-run? ``` org.apache.maven.plugins maven-compiler-plugin ... ... -parameters ``` Ideally this wouldn't be needed to use the library, but...

ah yes! We utilize jackson-module-parameter-names to avoid having to jackson-annotate all of our creator parameters. This is included in the library, but requires your application to enable the feature on...