Konrad Windszus
Konrad Windszus
@brobatr You don't need access to this repo to raise a PR: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork
> * Is this only an issue when the `@Self` injector is used? Or is it enough to inject the underlying `SlingHttpServletRequest`? Any means to inject and store the adaptable...
Indeed, sorry for that. One commit message had a wrong reference in it. I just reopened. Can you come up with a PR for this issue?
This report is lacking crucial details, like AEMaaCS version. Please make sure to comply with prerequisites listed at https://adobe-consulting-services.github.io/acs-aem-commons/pages/compatibility.html.
https://github.com/policeman-tools/forbidden-apis/issues/34
This also affects e.g. help given out via https://maven.apache.org/plugins/maven-help-plugin/describe-mojo.html but agree this is just a minor issue.
The default version of Palantir in https://github.com/diffplug/spotless/blob/main/lib/src/main/java/com/diffplug/spotless/java/PalantirJavaFormatStep.java#L32 needs to be raised to [2.71.0](https://github.com/palantir/palantir-java-format/releases/tag/2.71.0) to fix this issue there as well.
Unnamed variables are supported i. palantir 2.74+ (https://github.com/palantir/palantir-java-format/releases/tag/2.74.0).
I would place this in [`org.apache.jackrabbit.oak.namepath.impl.GlobalNameMapper`](https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/namepath/impl/GlobalNameMapper.java) and then call this from according `getOrCreateOakName(orNull)` which should be used from all JCR methods potentially creating items (with expanded names). This should be...
Look at https://github.com/eclipse-jdt/eclipse.jdt.core/blob/master/org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/tool/EclipseCompiler.java how ECJ is implementing that. JSR 199 has additional details: https://jcp.org/en/jsr/detail?id=199