Konrad Windszus
Konrad Windszus
For me the biggest downside of RMM is the additional complexity of pulling the rewrite map file from AEM, therefore I would currently state as a rule of thumb: Use...
I agree that we should merge the two by extending RM with the RMM capability (not the other way around) as maintenance is much easier with RM. @joerghoh Is there...
Merging this PR makes sense after a release containing the code changes, not before. Apart from that I agree.
I also run into this issue, I guess this somehow is incorrectly parsed as [sealed class](https://openjdk.org/jeps/409), therefore at least Java 15 is required. Lower Java versions lead to that error....
Probably https://github.com/palantir/palantir-java-format/blob/dd02940abda1abe91a824b7ca06d49c3539e5e47/palantir-java-format/src/main/java/com/palantir/javaformat/java/ModifierOrderer.java#L146 needs to be conditional (depending on the current Java version).
I created https://github.com/google/google-java-format/issues/1224 to track this in the Google Java Formatter as the support of sealed classes has been backported from there.
Maybe the approach in https://felix.apache.org/documentation/downloads.html (https://github.com/apache/felix-antora-site/edit/main/modules/ROOT/pages/downloads.adoc) works better. There the link is only resolved once the user clicks on download. No need for executing lua scripts (with potential performance penalty)...
FTR: This is available from https://github.com/olamy/jacoco-aggregator-maven-plugin. @olamy Thanks a lot!
FTR: The default being `true` comes from https://github.com/jacoco/jacoco/blob/e21a0b13a9da4aecb4b3c60faeacf45a5b11b9db/org.jacoco.core/src/org/jacoco/core/runtime/AgentOptions.java#L287.
flexmark seems to be dead (https://github.com/vsch/flexmark-java/issues/664), not sure how easy it is to switch back to https://github.com/commonmark/commonmark-java/...