kwcantrell

Results 32 comments of kwcantrell

Thanks @fedarko and @ElDeveloper for the initial feedback. I was able to make some substantial changes by addressing some of the things brought up. > I really, really like the...

I simplified this PR a bit. Please look at updated PR description.

Thanks @fedarko and @ElDeveloper! I think I have addressed all of your comments so this pr should be good to merge.

@fedarko I updated the message for the non-numeric warning message for feature metadata coloring and added some test. I fixed the bug were the gradient bar would overflow the legend....

I fixed the legend gradient bar issue by placing the gradient svg within a div container. It now will be initialized as 80% of the legend size but will not...

> Furthermore, I think this problem isn't just with the tree exporting -- these nodes actually aren't getting assigned colors, and we've been lucky in that this lack of color...

I had originally looked into this when I split the tree into a color/coordinate buffers. The idea was to create a drawer for the tree and then overlay another drawer...

Thanks @gibsramen. I ment phylogeny not taxonomy

> Is the idea here that the internal nodes in the phylogeny could have some notion of the taxa that descend from it within the phylogeny? > > If so,...

I guess I am not familiar enough with how the taxonomy is calculated to properly comment on this. But I would assume that the taxonomic level of internal nodes would...