Kavindu Vindika

Results 7 comments of Kavindu Vindika

I found the following error with the removal of disable eslint. ![fix1](https://user-images.githubusercontent.com/53901190/66710355-2b5d7a80-ed94-11e9-88bc-b007cc1a7998.png) Once I fixed it, following lint errors popped up. ![fix2](https://user-images.githubusercontent.com/53901190/66710363-68297180-ed94-11e9-887a-399eeda6cc52.png) Both errors comes as `eslint(react/jsx-indent)`. I found similar...

shall I use the following propType to specify the range, by importing PropTypes as `prop-types`. `categorySuggestionsListSize: PropTypes.oneOf([1, 2, 3, 4, 5, 6, 7, 8, 9, 10]),`

To remove the eslint issue I revert back to a previous commit and move the code changes again. For `propTypes` custom prop type was defined. And I tested it locally...

Shall I work on this...I have to work on a contribution to an open source project for an assignment in our university..

@jyash97 @metagrover please review the above PR for the added `categorySuggestionsListSize` prop. Now it can be added as `categorySuggestionsListSize={*}` in CategorySearch component.

Hey, I would like to work on this

Hey @kud @jyash97 Need to clear some points. `renderNoResults` and `renderSortOptions` are written in similar manner, and render to the dom as follows. `.......{this.props.sortOptions ? this.renderSortOptions() : null}` `{!this.props.isLoading &&...