reactivesearch Improve CategorySearch in web

fix #814

Oct 03 '19 05:10 kvin97

Can you also follow the PR template? They are present for a reason so that we don't miss documentation or other things related to PR.

Oct 03 '19 15:10 jyash97

@jyash97 Can you review it?

Oct 08 '19 10:10 bietkul

I found the following error with the removal of disable eslint. fix1 Once I fixed it, following lint errors popped up. fix2 Both errors comes as eslint(react/jsx-indent). I found similar kind of issue here. https://github.com/yannickcr/eslint-plugin-react/issues/1679

Oct 13 '19 03:10 kvin97

shall I use the following propType to specify the range, by importing PropTypes as prop-types. categorySuggestionsListSize: PropTypes.oneOf([1, 2, 3, 4, 5, 6, 7, 8, 9, 10]),

Oct 13 '19 03:10 kvin97

I think there is some eslint config issue on your side as I tried changing things on the same file and could not replicate.

Also for propTypes you may need to define a custom prop type.

Oct 14 '19 08:10 jyash97

To remove the eslint issue I revert back to a previous commit and move the code changes again. For propTypes custom prop type was defined. And I tested it locally rigorously.

Oct 20 '19 10:10 kvin97