Koorous Vargha

Results 17 comments of Koorous Vargha

We may want to add exponential backoff [here](https://github.com/linkedin/venice/blob/6918083b5de67740f0ae6e43276b83ab5fcf2fa2/internal/venice-common/src/main/java/com/linkedin/venice/utils/HelixUtils.java#L230-L243) to account for any network or ZooKeeper issues.

Closing PR as Helix resources do get cleaned up when receiving a kill job message, which was observed during my testing. The child controllers invoke `VeniceHelixAdmin#deleteOneStoreVersion` which calls `VeniceHelixAdmin#deleteHelixResource`

> NB: I believe this change could lead to race conditions due to Utils.sleep, although there are other methods in HelixUtils which are using Utils.sleep as well, and all methods...

Some minor nits, but great job! This PR is almost ready to go.

Code looks good to me, but it looks like SpotBugs is failing. Try running this locally and look for the HTML file path it outputs detailing the errors. `./gradlew :internal:venice-common:spotbugsTest`

Closing as contributor is unable to continue working on this