[controller] Helix resources should be removed after a VPJ kill job

[ishwarya-citro]

Summary, imperative, start upper case, don't end with a period

When VPJ initiates the kill-job command, the kill-job commands didn't remove the Helix resource. Added logic to include the helix resource deletion whenever a VPJ fails.

Everytime a VPJ runs the killOfflinePush job, it does not remove the helix resources. As part of the job, it calls the killOfflinePush but does not call the method to remove the helix resource.

Changes follow an example of it doing the killOfflinePush & removing helix resource correctly like here and here.

How was this PR tested?

unit tests

Does this PR introduce any user-facing changes?

• [X ] No. You can skip the rest of this section.
• [ ] Yes. Make sure to explain your proposed changes and call out the behavior change.

[nisargthakkar]

Hi @ishwarya-citro. We should not include non-public information in open-source PRs. Can you remove the ticket reference?

[kvargha]

Closing PR as Helix resources do get cleaned up when receiving a kill job message, which was observed during my testing. The child controllers invoke VeniceHelixAdmin#deleteOneStoreVersion which calls VeniceHelixAdmin#deleteHelixResource