venice icon indicating copy to clipboard operation
venice copied to clipboard

[da-vinci][controller] Add check to ensure version is valid before ingestion

Open tylerhu3 opened this issue 1 year ago • 1 comments

Summary, imperative, start upper case, don't end with a period

Add check to ensure version is valid before ingestion

Resolves #657

How was this PR tested?

Ran "./gradlew check --continue"

Does this PR introduce any user-facing changes?

  • [ X] No. You can skip the rest of this section.
  • [ ] Yes. Make sure to explain your proposed changes and call out the behavior change.

tylerhu3 avatar Jul 24 '24 02:07 tylerhu3

Based on the original issue, we still only add a check here as opposed to trying to create one if it doesn't exist? The issue also suggests to try to create one if not exists and then fail if the creation fails.

Do we plan to add that in subsequent PRs? If so, I 'd clarify the description to specify it partially resolves the issue.

mynameborat avatar Jul 29 '24 18:07 mynameborat

Closing as contributor is unable to continue working on this

kvargha avatar Feb 06 '25 22:02 kvargha