Jakub Konka

Results 120 comments of Jakub Konka

Is the failure of the CI related to the PR? Would you be able to tell? I'm happy to merge this but wanna make sure the failure is actually some...

I'm looking at the test failure, and it seems to me that the code signature injected for x86_64-macos, which shouldn't be the case.

> I'm looking at the test failure, and it seems to me that the code signature injected for x86_64-macos, which shouldn't be the case. I was thinking about the failure...

> Maybe write this as `16 * 1024` so nobody has to go through any mental gymnastics to interpret `0x4000` (not everyone thinks in hex so readily). Hmm if we...

I think that's a very cool idea! I'm not sure if/how useful this might be, but I've had to play a little with user-space exposed Mach calls (which have kernel-space...

> The kernel page-in technique is indeed interesting. > > There are several ways encoding a relative relocation. In terms of space efficiency, I think the sorted order is: >...

> "Wasm" is an abbreviation, while "WASI" is an acronym, and they really are written with different styles in practice today. > > Is that too confusing? It's probably still...

> @sunfishcode what is a correct place to add new flags for rights? I'm getting > > ``` > error[E0425]: cannot find value `__WASI_RIGHT_SOCK_CONNECT` in this scope > --> crates/wasi-common/src/wasi.rs:42:7...

> I'm stuck with writing a first test, any advice here? I run tests with > > ``` > cargo test socket --features wasm_tests -- --nocapture > ``` > >...

@sunfishcode @alexcrichton @peterhuene I'm not sure whether review requests work in Draft PR mode so I'm cc'ing all of you. Apologies for this additional spam!