Chris Trześniewski

Results 59 comments of Chris Trześniewski

It seems like to many files are published to the repository. According to this article https://medium.com/@nikolasleblanc/building-an-angular-4-component-library-with-the-angular-cli-and-ng-packagr-53b2ade0701e#8dd5 only `./dist` folder should be published. When I moved everything from the `./dist` folder...

Thank you @phbasler for filing an issue. I'll try to fix it soon

hi @michaelmior thank you for your contribution. Is this PR ready to review? Do you need any help to push it to the finish line?

Hi @jefchien Thank you for your contribution! Could you please explain to me a bit more why would we want to provide the SHA as an input rather than just...

hi @LinqLover Thank you for the idea and your contribution! I like the idea in general but I need to think about it. I'll get back to you soon :)...

hi @ColinEberhardt This is weird and should not happen. Unfortunately, logs are not available anymore Anyway, I would suggest to not set `auto-push` option for benchmarks on a PR as...

Hi @MingweiSamuel As specified in the docs the `github-token` is necessary for adding commit comments https://github.com/benchmark-action/github-action-benchmark#commit-comment It is also necessary in case of [scheduled](https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#schedule) and [manual](https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#workflow_dispatch) runs to fetch the...

hi @michaelmior Thank you for your suggestion. I actually did something similar on another project by refactoring this project's code a bit. I might take a try on applying a...

hi @seanmonstar Thank you for your contribution. Could you please resolve conflicts and add a test example that will verify your change?

Hi @clicketyclackety Are you able to share what is the result of the `.\scripts\RunBench.ps1` script? I'm not sure where exactly is this error occurring. There is no place in the...