github-action-benchmark icon indicating copy to clipboard operation
github-action-benchmark copied to clipboard

Custom type with combined bigger/smaller is better

Open michaelmior opened this issue 4 years ago • 1 comments

In addition to customBiggerIsBetter and customSmallerIsBetter it would be nice to just have a simple custom type where the JSON output would include "better": "bigger" or "better": "smaller" so that a single benchmark could make use of both. For example, I might want to measure both memory use (smaller is better) and throughput (bigger is better) for a single benchmark. While I could potentially save the results to a file and split them apart into two separate benchmark outputs, it would be simpler if this was not necessary.

EDIT: Having a quick look at the current code structure, I can see this probably isn't easy to do but it still would be nice :)

michaelmior avatar Oct 29 '21 18:10 michaelmior

hi @michaelmior

Thank you for your suggestion. I actually did something similar on another project by refactoring this project's code a bit. I might take a try on applying a similar refactor here as well.

ktrz avatar Oct 29 '21 19:10 ktrz