Kohei Tokunaga

Results 137 comments of Kohei Tokunaga

> How can I check the golint error log? GitHub action did not provide much info to help me pass the CI. Golint output is supposed to be logged to...

Recent test flaky seems to be because of recent updates of one of the images (`nginx`) used in CRI validation test. I'm working on fixing this (please see also https://github.com/kubernetes-sigs/cri-tools/pull/618...

Fixed CI flaky(https://github.com/containerd/stargz-snapshotter/pull/106) and am done the read performance improvement(https://github.com/containerd/stargz-snapshotter/pull/105). Can you rebase?

This patch intended to provide a way to share pre-defined record files to such tools that don't have container runtime functionality (e.g. crane by go-containerregistry).

> The labels here seem to serve the same purpose as these other than the TargetPrefetchSizeLabel. > Is there a reason for those three label keys to diverge? Could they...

@xujihui1985 Yes, I really would love to integrate to Docker. I've worked on moby/moby#41002 but it does not reach to the agreement. There are also on-going issue moby/moby#38043 and moby/moby#38738...

Interesting. Mounting stargz as "bootfs"? I'll take a look.

Thanks for the suggestion! We agree with all of the following requirements. Just needs more time & help for implementing them. > 1. flatten fuse mountpoint instead of multilayer with...

https://github.com/containerd/stargz-snapshotter/runs/7780320865?check_suite_focus=true#step:4:2353 ``` #13 194.1 # github.com/containerd/containerd/pkg/cri/sbserver #13 194.1 pkg/cri/sbserver/instrumented_service.go:37:9: cannot use &instrumentedService{…} (value of type *instrumentedService) as type grpcServices in return statement: #13 194.1 *instrumentedService does not implement grpcServices (missing...

SGTM about the statically built livenessProbes.