Standard remote snapshot labels?

[jonjohnsonjr]

The labels here seem to serve the same purpose as these other than the TargetPrefetchSizeLabel.

Is there a reason for those three label keys to diverge? Could they be reused instead?

I was digging through nerdctl and came across this, which has some hard-coded logic for stargz. I'm wondering if it's possible to agree on some standard configuration for determining whether or not something is a remote snapshotter rather than looking specifically for stargz there... what do you think?

[ktock]

The labels here seem to serve the same purpose as these other than the TargetPrefetchSizeLabel. Is there a reason for those three label keys to diverge? Could they be reused instead?

Yes, these label keys are diverse but have the same purpose. For tools other than CRI plugin (e.g. BuildKit, nerdctl, etc), default labels should be used.

I was digging through nerdctl and came across this, which has some hard-coded logic for stargz. I'm wondering if it's possible to agree on some standard configuration for determining whether or not something is a remote snapshotter rather than looking specifically for stargz there... what do you think?

Isn't referring snapshotter name enough? What's your use-case for this?

Stargz-related configurations are hard-coded to some of stargz-aware tools as of now and I agree that we should make them configurable (especially for making it easier to integrate other types of (non-stargz) remote snapshotters).