Martijn van Beurden

Results 268 comments of Martijn van Beurden

Thanks for providing the stream. This seems related to #254 Can you provide some more information on how you are using libFLAC? It seems you're not using the `flac` command...

Getting this fixed properly will take a lot of work, which has been on my TODO list for more than a year now. There is a PR (#261) implementing basis...

I can't verify this. #494 is related.

`metaflac` does not offer a way to do this currently. Why do you want to remove it?

If you contribute a PR, it could be implemented next week. If not, I won't make any promises. As you can see from the issues list, there are open issues...

Sure. It is right here https://github.com/xiph/flac/blob/31ccd3df31f912bac76e669c2fbf347adf2bf235/src/libFLAC/format.c#L47-L59

That depends on what action metaflac does, specifically. Taking adding a vorbis comment block when there is none as an example, that would be. Here: https://github.com/xiph/flac/blob/31ccd3df31f912bac76e669c2fbf347adf2bf235/src/metaflac/operations_shorthand_vorbiscomment.c#L63 Then here: https://github.com/xiph/flac/blob/31ccd3df31f912bac76e669c2fbf347adf2bf235/src/libFLAC/metadata_object.c#L468

I don't know what to make of this. FLAC calls fflush after **every fwrite**, so large buffers should not make a difference? Even with setvbuf, fflush is honoured as far...

> I don't think fflush is called every frame, fflush is present only when FLAC__VALGRIND_TESTING is defined on encode and decode, presumably only in test and/or debug builds. Yes indeed,...

> * Determine what targets a large buffer cannot be used with and exclude them I haven't looked into your changed in depth, but I would consider moving the `flac`...