Martijn van Beurden
Martijn van Beurden
Hi @philippe44, sorry it took quite a while to review this. I think the code looks nice, but it would be even nicer if as much of it as possible...
No. However, you can help along by explaining your use case? The main problem I currently have is that I want to implement this in a way that covers as...
> such a brutal bug This is no bug, this is a missing feature, and a rather complex one too. Sure, this looks like 'just keep playing' but to me...
@philippe44 I took a few hours to study your approach in-depth and I think it is rather nice. However, I would like to make some changes. Normally I would make...
`metaflac` doesn't support writing to Ogg FLAC at all, not just pictures. So yes, the only way to embed pictures in Ogg FLAC currently is reencoding. This has been on...
> Not sure if the `last_seen_framesync` should be two bytes after the start of the frame, but in case this is wrong this line might be the issue (reads the...
Oh, and by the way, thanks for reporting!
> > Furthermore, here the stream contains samples that do not fit within the bit per sample of the stream. If further processing is done on these, that could result...
> One thing I just though, should I create a separated issue for this? > > > Next thing is the FLAC__STREAM_DECODER_ERROR_STATUS_FRAME_CRC_MISMATCH error (or whatever error is sent in that...
Just as a note to self: to improve troubleshooting, maybe it is a good idea to add extra FLAC__Frame subframe types. Maybe something like FLAC__SUBFRAME_TYPE_OOB (out-of-bounds) and FLAC__SUBFRAME_TYPE_FILLER (for filling...