Martijn van Beurden
Martijn van Beurden
Yes, it could. However, implementing multithreading for decoding will be more complicated than for encoding. Also, there are more things that can go wrong in decoding than encoding. I don't...
Have you seen this: https://xiph.org/flac/api/group__porting.html Seems pretty comprehensive to me?
Can you please share what error you get without this patch? Skipping ID3v2 tags has been in flac for a long time, so I am unsure why this PR would...
You're trying to re-encode through errors. Functionality is indeed more limited than pure decoding, and this is not the only example. I'll need some time to review, but following the...
Does the decoder at least return an error that it didn't restore the metadata correctly?
Hi, Many thanks for filing a PR. I haven't tested it, and as you might understand, this will need a lot of testing :) I've tried doing this in the...
By the way, perhaps we should also define a new STREAMINFO metadata block variant.
> There's also another reserved bit in the frame header No, there isn't. The code still refers to it, but the RFC made it part of the sync code. That...
~I wonder why oss-fuzz didn't catch this one. Probably need to check that too.~ Nevermind, this is in the vendor string. That function isn't being fuzzed because it is something...
Thanks for all the work you did on this one. And thanks for chopping this up for me. It is still quite a large PR (for documentation anyway) but doable....