Kristen Thyng comments

Results 355 comments of


                                            Kristen Thyng

Question: how does ROMS work for 3D without zeta included?

Here is how I understand it and see if we agree. Thinking about it in terms of height above seabed because that is straight-forward: * A drifter depth of z=0...

Question: how does ROMS work for 3D without zeta included?

Thank you, I should be able to get back to this and other on-going development work on opendrift by mid-next week.

Question: how does ROMS work for 3D without zeta included?

I am working on another PR that addresses seafloor checks that incorporate zeta and an additional parameter that wetting/drying models have (or at least ROMS does but I think this...

Question: how does ROMS work for 3D without zeta included?

Yes, `interact_with_seafloor` is where I've made changes. Now I see I should also modify the vertical_mixing routine in OceanDrift which also checks the seafloor boundary twice and calls `interact_with_seafloor`. I...

Question: how does ROMS work for 3D without zeta included?

@knutfrode I'm writing some tests and had a realization — since z must be

Add zeta to sdepth in depths.py (part of effort to add zeta to ROMS reader)

Ok sounds good!

Add zeta to sdepth in depths.py (part of effort to add zeta to ROMS reader)

ok I added in my addition of zeta to the ROMS reader now too which was missing before.

Add zeta to sdepth in depths.py (part of effort to add zeta to ROMS reader)

Thank you, I should be able to get back to this and other on-going development work on opendrift by mid-next week. In particular I have some changes to allow for...

Add zeta to sdepth in depths.py (part of effort to add zeta to ROMS reader)

I'm digging back into this work today so I'll see what I can figure out too.

Add zeta to sdepth in depths.py (part of effort to add zeta to ROMS reader)

Yes I agree that would be a better path. I'd be happy to make changes to roppy directly if @bjornaa would be interested.