Kristen Thyng

As you probably know, ROMS has `s_rho` and `s_w` stretching vertical coordinates which have to be mapped to depth based on some of the grid details and the sea surface...

The ROMS reader does seem to think the depths should be negative, for example: https://github.com/OpenDrift/opendrift/blob/15546beb529f0d94629dc971a00b6edcb80dbf2b/opendrift/readers/reader_ROMS_native.py#L74-L78 unless I am over-interpreting those lines as being more meaningful than they are.

@knutfrode Ah I realize now I conflated the depths of the drifter with the overall seafloor depth. Thank you for that clarification! I dug in and see the reason for...

Just wanted to follow up here — any advice on using OpenDrift with wetting and drying model output? Is there any special handling in this case? I can imagine if...

> Coastline stranding is determined by the binary landmask (land_binary_mask) and not the ocean depth variable (sea_floor_depth_below_sea_level) Ok that makes sense, though what about in the scenario that the following...

As a follow up, I used the wet/dry mask as the land binary mask and allowed it to vary in time to solve my problem. Thanks for your guidance.

@knutfrode Well I have fixed some issues regarding the wet/dry mask. However, I am diving deeper now and I see more items. As part of this, I see that in...

It looks like the "bad" values are always replaced with nan regardless of the fallback value: https://github.com/OpenDrift/opendrift/blob/7aae898f383052e803e28aef6d32434327f4520d/opendrift/readers/basereader/variables.py#L642-L650 If we were to change the minimum depth value to -10 to allow...

@knutfrode Yes changing the consts.py code does fix the issue of the warning that my wet/dry cells have been nan'ed out. ``` 'sea_floor_depth_below_sea_level': {'valid_min': -10, 'valid_max': 12000, 'long_name': 'Depth of...

@knutfrode Yes thank you, this resolves this issue. I plan to submit a PR for the ROMS reader with my changes for using the wet/dry mask as well as a...