Kristen Thyng
Kristen Thyng
I am afraid this issue of wetting/drying has again become more complex than I realized. I was able to incorporate the wet/dry mask into the ROMS reader and you fixed...
Ok thank you.
I have to stare a little harder at the roppy code to be sure but it looks the same as e.g. what I have in xroms but without zeta: https://github.com/xoceanmodel/xroms/blob/c42b795e6e08cd77e038e2845c627d858c7705df/xroms/xroms.py#L202-L205...
Oof, I was hoping the changes would only need to occur in the ROMS reader. I am happy to handle the changes in the ROMS reader but I am worried...
> I assume you would like to see this implemented as soon as possible? Ideally, yes. If you're able, when might you be able to work on it? I've been...
> Thus zeta must now be always available as an environment variable, but will default to 0 if not provided e.g. from a ROMS file Does this mean that if...
@knutfrode I am opening up a [PR](https://github.com/OpenDrift/opendrift/pull/1238) so you can see what I've done and get feedback on next steps. You could work on the same PR if you want,...
I'm not sure I understand your question. If it is in response to my question about the default, I just meant I wasn't sure where to put the default of...
@knutfrode So if z is at depth it incorporates zeta https://github.com/kthyng/opendrift/blob/54201a6f8805d565f72f23a024deaccea6cf7d62/opendrift/readers/reader_ROMS_native.py#L425-L434 However if it is at the surface it is not incorporated yet. Perhaps I could have `variables['z']` be equal...
@knutfrode I like your pragmatic solution and so far don't see anything wrong with it. I can work try it out from my end today and see how it works....