Yoshiya Hinosawa

Results 643 comments of Yoshiya Hinosawa

Maybe better to match against URL string, instead of path string (which can be `\` delimited in windows)?

@edilson258 Thanks for working on `deepStrictEqual`. The change in `deepStrictEqual` looks good to me. The test files under `tests/node_compat/test/parallel` are [copied](https://github.com/nodejs/node/blob/main/test/parallel/test-sqlite-transactions.js) from Node.js repository. Those tests are passing with Node.js....

> If the error is not from settled promises, I think we should throw the error from the catch block instead. I think we should aggregate both errors and set...

> Should updates to those affected tests be addressed in separate, forthcoming PR(s)? We generally don't merge PRs to main which makes CI check red. Can you try to address...

Do you see the same error with Deno 2.0.2? We changed dns.lookup a little bit in https://github.com/denoland/deno/pull/26264 , and that might have affected it. Also how does the same code...

> > Do you see the same error with Deno 2.0.2? > > Yes Sorry, I made mistake in checking the shipped version of #26264 Could you also check with...

> I need the functionality to find the k'th node in the tree, which isn't possible with current setup This change doesn't seem a good idea for adding that capability...

> I don't think it's the worst thing to make the BinarySearchNode a public class, as we have already made it a "binary" tree, so having left/right/parent elements is expected...

This doesn't change `createServeDirResponse` and request body is still returned when the file server returns directory listing (You can check `assert(!res.body)` fails with the url `http://localhost/nested-subdirs/subdir/`). We need to modify...