Yoshiya Hinosawa comments

Results 643 comments of


                                            Yoshiya Hinosawa

refactor(fmt): add unit arrays

Let's not do this. It seems very confusing to include many of unused values in the source code

use jsr modules where possible and upgrade fresh version

Reverted in #703. Now https://saaskit.deno.dev/ seems back I just realized this changes the preact specifier without changing the fresh version. Is it possible to use different preact version than what...

BREAKING(http/unstable): switch `params` and `info` args in `Handler` in `route()` for more conveniency

We recently removed the dependency to (unstable) `route` in main of CLI (in `deno init --serve`). ref. https://github.com/denoland/deno/pull/26595 I think we still need to wait for a while (at least...

BREAKING(http/unstable): switch `params` and `info` args in `Handler` in `route()` for more conveniency

We've released 3 versions of CLI (2.1.0, 2.1.1, 2.1.1) which don't use unstable `route` function in `deno init --serve` output. I think it's time we can land this.

feat(net): named pipe support via `Deno.pipe`

Is this `Deno.pipe` namespace aligned with the rest of Deno APIs? I think we usually express this kind of variation as `transport` option of `Deno.connect`. `Deno.pipe` namespace looks like random...

feat(net): named pipe support via `Deno.pipe`

Ok. Thanks for the clarification

`deno run -A npm:create-next-app -e hello-world` does not work

Confirmed this is fixed with the latest version of `npm:create-next-app`. Closing > just need to fix the failed test I'm not very sure where these tests are. Is that still...

feat(twas): refracto to use intl api

I would only show the largest unit like: ```js if (duration.years >= 1) { return formatter.format({ years: duration.years }) + " ago"; } else if (duration.months >= 1) { return...

suggestion: add `bcrypt` and `argon2` support to `std/crypto`

We already use wasm in std/crypto implementation https://github.com/denoland/std/tree/main/crypto/_wasm Do you suggest adding `bcrypt` and `argon2` to std/crypto digest API? Or do you suggest API specific to password hashing?

fix(coverage): Exclude comment lines from coverage reports

Tested `istanbul` (via `jest`). The comment lines seem excluded from total line count.