Yoshiya Hinosawa comments

Results 643 comments of


                                            Yoshiya Hinosawa

fix: return exit code 1 when dead links found

Hey, sorry for the delay. I updated the test cases to pass them on windows. Please run the CI again (Note: I experimented the windows run in https://github.com/kt3k/markdown-link-check-clone/pull/1 )

refactor(cli/unstable): print progress bar when `value` and `max` are changed

> No. I very likely could be updating value 100x a second. That is a lot of wasted prints. What would be the maximum reasonable number of re-rendering in a...

refactor(cli/unstable): print progress bar when `value` and `max` are changed

> I think an inconsistent update interval though could give the effect that the program is having lag spikes and any "delta" values that are introduced or manually calculated via...

Is assertObjectMatch too type-strict?

This looks related to this issue in typescript https://github.com/microsoft/TypeScript/issues/15300 You can fix the issue by using `type` for `FirstLast` instead of `interface` like: ```ts type FirstLast = { first: string;...

Add abbreviation section to style guide

Abbreviations in variable names, function names, argument names, etc are very common across Deno projects (Deno CLI, std, etc). (For example, `rid`, `conn`, `req`, `res`, etc) I don't think this...

`pino` logger doesn't work in Deno

Ah, yes. Thanks!

Better TOML types

Run `deno fmt` to format the source code

Better TOML types

We currently don't accept a new feature directly, but we'd like to accept it as unstable feature first (See https://github.com/denoland/std/blob/main/.github/CONTRIBUTING.md#suggesting-a-new-feature ) Let's keep the return type of `parse()` to `Record`,...

Use of locale-sensitive methods with `undefined` locale may cause environment-sensitive bugs

Can this be closed now?

`randomSeeded` only gives 32 bits of entropy (whereas `Math.random` gives 53 bits)

fixed by #6626