Yoshiya Hinosawa
Yoshiya Hinosawa
Because this module formats the value as byte numbers by default, setting max=1 as default feels strange to me. > I'm not a fan of this change as, I imagine...
Looks in a good direction to me. Can you write some simple test cases of `setBroadcast`, `dropMulticastV4`, and `dropMulticastV6` of `DatagramConn` class in `tests/unit/net_test.ts`? Also can you write test cases...
Seems reasonable suggestion to me. PRs are welcome!
I still think this suggestion is reasonable, but I'm against #6289 which makes the maintenance of `@std/testing/mock` and `@std/expect` difficult. We got stuck in review of #6317 because it implemented...
Looks like this started from #22944 (Its parent commit ( e40f9a5c14c51b6d05812e48fa072148fe79c74d ) doesn't have this issue) https://github.com/denoland/deno/pull/22944/files#diff-d79583d80aaeb5ef9a59ecdd138bfd64ac89793f594321f1fce5d8625c1e07e2R800-R808 In these lines, we consider child workers, but we don't take pending async...
We consider Web Streams (ReadableStream and WritableStream) as the main way of I/O in Deno https://github.com/denoland/deno/issues/11288 https://github.com/denoland/deno/issues/9795 `write` and `writeSync` remain there only for backward compatibility purpose. The recommended way...
Maybe we can consider making `stdout.writeSync` work like `writeAllSync`. > I'm struggling to think of any low-level use case where it'd be preferable to bail part-way through in an unspecified...
Looks like we need to update test common script somehow (That script is probably now outdated)
@edilson258 Thanks for the PR. The maintainers will work on the fixes for the existing test cases (they should be passing as is). Please wait for a moment.
pushed a potential fix https://github.com/tcort/markdown-link-check/pull/452/commits/f55187526ba5369d5864cee33f8b663706c336f1