Yoshiya Hinosawa
Yoshiya Hinosawa
@CoenraadS I couldn't reproduce the data corruption using the repro.zip (main.js) with the latest Deno on Windows Server 2022 and MacOS 13.3. Can you still reproduce the error with the...
@CoenraadS Thanks. Now I'm able to reproduce the issue consistently with ~20 iterative checks on macOS. ~~The issue (with fs.writev excluded) seems to have started from Deno 1.39.3. It doesn't...
@dy-dx Thanks for the input! ~~Looks related to this issue. I tried the patch https://github.com/nodejs/node/pull/52005 together with https://github.com/nodejs/node/pull/46818, but it didn't fix the given example (it still shows `worldhello`).. Do...
Isn't the below structure enough easy/straightforward to understand? ```ts for await (const stream of streams) { for await (const chunk of stream) { // process chunk } } ``` I...
Fair enough
This change makes sense to me. However because this is a breaking change, we're planning to land this at v1.0
`await waitForMicrotasks()` part in the above example looks inaccurate to me (it looks waiting more than microtasks). The suggested util (`promiseState`) in [this stackoverflow answer](https://stackoverflow.com/a/35820220) looks more general (supporting rejected...
The expectations in only_test.ts looks good to me, but let's not consider flat test grouping nested inside other suites like the below: ```ts describe("outer 2.2", () => { describe(onlyTests, "inner...
Added snapshot test case to check the output of the given example. Now the below existing test cases are failing: ``` global ... describe ... only ... signature 1 ......