Yoshiya Hinosawa comments

Results 644 comments of


                                            Yoshiya Hinosawa

assertEquals can't show a helpful diff and a provided message

Now I think showing both message and diff would be simpler and better than accepting custom formatter.

Include an `accept-language` parser

Ok. Let's close. @lucacasonato Please reopen if you have any further suggestion/opinion

Add GraphQL Server

Ok. Let's close for now.

Some util.inspect (of `node/`) test cases fail with `Fatal process OOM in RegExpCompiler` in ubuntu

We are replacing the implementation of util.inspect with Deno.inspect now (https://github.com/denoland/deno/pull/17960 ). Let's revisit this when we see the same error again with the new implementation

Don't unnecessarily request to read environment variable

Deno doesn't ask env permission for accessing `NODE_DEBUG` (ref: https://github.com/denoland/deno/pull/15893)

feat(message): Add new message interface

I agree with @Symbitic on the below > Message categories/loggers shouldn't be exported by modules. Ideally, usb would create usbLogger in deps.ts and not make it visible to other modules....

feat(message): Add new message interface

Closing because of inactivity. If anyone feel strongly about this proposal, please open a new one.

`walk` and `walkSync` skip over symlinks when `followSymlinks: false`

fixed in #3464 Now `includeSymlinks` defaults to `true`. Is there any concern on this default?

node: Reenable test for "net" module

Some are enabled now, and some are not yet. Let's track the remainings in `tools/node_compat/TODO.md` ref. https://github.com/denoland/deno/pull/18290/files#diff-66a13180ca921c746469f8f0bf6ec0cafab925839d65fdca6379866c4bb7be40

Implement Session Token expiration

Sorry, we don't actively maintain this project anymore. If you are looking for areas for contributions in showcase apps in denoland, I recommend you look into [saaskit](https://github.com/denoland/saaskit).