Yuki Kurihara comments

Results 83 comments of


                                            Yuki Kurihara

Introduce rubocop-on-rbs

@pocke Are you positive or negative about this change? I would like to hear your opinion.

Introduce rubocop-on-rbs

I have corrected the points raised. Also, changes to activesupport were rescinded to simplify the PR.

Fix type signature for `ActiveRecord::Base.validate` (to better support official Ruby documentation)

@yuzisee @tk0miya Thanks!

rqrcode: Fix type definition for RQRCode::QRCode#initialize

@aruma256 Can I help you?

Bump rack from 3.0.8 to 3.0.9.1 in /gems/yard/_generators

Updated in https://github.com/ruby/gem_rbs_collection/pull/542/files#diff-06719055b4b29f3b9315274c1a64d241154acdf5adf22854586b006e5cbaa272

Add type definitions to delete_all

Sorry for the delay in responding. - When modifying 6.0/activerecord-generated.rbs, move as far as possible to 6.0/activerecord.rbs. - I would like at least one line of testing.

stringio should be a stdlib, but it's in `core/`

I have a proposal. ## Our goal I believe stringio is already gemmed and the goal is to move to gem. https://github.com/ruby/stringio ## Problem One thing to be aware of...

extend module in RBS sig not declaring module instance methods as singleton methods of extended module

I could not reproduce the problem in my environment. Please let me know your environment. My environment is here. ``` * rbs (3.9.1) * steep (1.10.0) ```

extend module in RBS sig not declaring module instance methods as singleton methods of extended module

Since `def bar` appears to be an instance method, `foo` also looks like an instance method call. The warning seems to be correct.

extend module in RBS sig not declaring module instance methods as singleton methods of extended module

Thank you, I reproduced it. Perhaps steep is not able to support `module_function`. Supporting it would solve this issue.