kslimani

Results 65 comments of kslimani

I think that UK code is not included because this project use Alpha-2 codes from the [ISO 3166-1](https://en.wikipedia.org/wiki/ISO_3166-1#Coding) encoding list of the countries. _(it is an official list)_ Also interesting,...

I already handled something similar in the past. If i remember correctly, i used to store iso country code, but also an optional (not iso) region code. The optional region...

This project is about ISO 3166-1 country codes list and "UK" code is not officially included in this list. I don't think it is a good idead to add it...

@flavioribeiro : i think @SeriousShit is correct. the downloader `http.go` is using the old grab api (ie: the method `grab.GetAsync` is undefined in current grab library master branch. I suggest...

Oh, and i think there is also a problem with snikers/hls : i think the build for libsegmenter.so is ok, but it seems theere is a path problem to the...

My proposition is to add these modifications _(not added yet to current pr #75)_ : ```javascript _hasDuplicateValue(objArray, key) { let hash = Object.create(null) for (let i = 0; i <...

Maybe rename method `_hasDuplicateValue` to `_hasDuplicateObjectValue` _(method expects an array of object as first parameter, and second parameter is the name of object property to check for duplicate value)_ Yes,...

In future version of Clappr i think we could remove completly label formatting logic from playback plugins, and normalize array of object provided by `PLAYBACK_LEVELS_AVAILABLE` event; and move all the...

awww, the previous provided solution does not work in all case. There are some manifest with multiple time the same height, with the same language, but different bitrate... I am...

currently, i see 2 solutions : First solution is to always use bitrate for label and check if video tracks has multiple audio languages. If this is the case, then...