kslimani

Results 77 comments of kslimani

Let's hold this PR until i have the hand again on mobile/desktop devices (covid-19 containment) to ensure it will works.

aren't .m3u8 files supposed to be handled by HLSJS playback (or Flash HLS or Native on some device) ? @tanquetav maybe it should be better to add a plugin option...

Maybe add a static method to enable HLS for example : ```javascript static set enableHls(isEnabled) { // [...] default is false, if set to true also check for 'm3u8' file...

@tchakabam @tanquetav i understand your point. But enabling hls playback by default on DashShakaPlayback will introduce a **breaking change**. Without any option to enable/disable this feature, if you load DashShakaPlayback...

@tchakabam when you add an external plugin to Clappr it is **automatically prioritized** over Clappr internal plugins. This mean, that if you automatically enable hls in DashShakaPlugin then is it...

An even more elegant way could be something like : ```javascript static withHls(isEnabled=true) { DashShakaPlayback._enableHls = !!isEnabled return DashShakaPlayback } static canPlay (resource, mimeType = '') { shaka.polyfill.installAll() var browserSupported...

@tchakabam if you have a solution to propose for enhance Clappr plugin loading order, feel free to create a PR or an issue on Clappr repository 👍

@tanquetav i tested your branch, and if enabling hls i got an error with shaka : category = 4 code = 4011 (which is "Errors parsing the Manifest.", "UNPLAYABLE_PERIOD" according...

hmmm it seems shaka player is currently bugged / unfinished for [hls source](https://shaka-player-demo.appspot.com/demo/#asset=https://bitdash-a.akamaihd.net/content/sintel/hls/playlist.m3u8;lang=en-us). Otherwise, the `withHls()` methods is working. 👍 @tanquetav would be nice also to edit readme file to...

Internally, Clappr player use the [hls.js](https://github.com/video-dev/hls.js/) library.