Piotr Krzemiński

Results 127 comments of Piotr Krzemiński

FYI I started applying this PR in smalller chunks (some smaller changes already merged), but I'm struggling to have a smooth experience with IntelliJ and these local convention plugins. I...

https://github.com/dependabot/dependabot-core/issues/2180 Is it true that after this change we won't have Dependabot updates? It's a major disadvantage to me 😢

Yes, Dependabot also handles plugin versions. Example: https://github.com/krzema12/github-actions-kotlin-dsl/commit/5f1d98754e9c77cce65f8e0896ed15fdc205bbeb Great, thanks, I'll give Renovate and version catalog a shot!

@aSemy would you be so kind to rebase these changes on newest main branch? Most of the minor ones should be already applied, and I'm most interested in using the...

In https://github.com/krzema12/github-actions-kotlin-dsl/pull/386 I'm merging a part of this PR - just the `kotlin-jvm` plugin, centralized repos management plus my little tweaks, to see how they work in practice and to...

Renovate works fine for the precompiled plugins: https://github.com/krzema12/github-actions-kotlin-dsl/commit/1832f83159d5b4896e313610312e342dbba8525a. I'll merge the rest of this PR soon-ish 😄

It took me a while to understand and merge this PR (in several pieces), but we finally did it! :muscle: Thanks a lot for sharing your knowledge about Gradle and...

Yep, totally agree. Actually it looks like a bug to me.

See https://github.com/krzema12/github-actions-kotlin-dsl/issues/80#issuecomment-1200504222, it will be fixed in scope of that task.

After addressing #80, it now works properly. See e.g. this test for jobs: https://github.com/krzema12/github-actions-kotlin-dsl/blob/9f803d557aa073c9dc35f6ecdc70807726cfe55f/library/src/test/kotlin/it/krzeminski/githubactions/yaml/JobsToYamlTest.kt#L273-L308