Piotr Krzemiński
Piotr Krzemiński
No immediate need to do it right now.
We calculate the checksums here: https://github.com/typesafegithub/github-workflows-kt/blob/fa2eb91b41615308b600fcd04fa914000ef55f9f/maven-binding-builder/src/main/kotlin/io/github/typesafegithub/workflows/mavenbinding/VersionArtifactsBuilding.kt#L18 Some time ago, it worked fine. I first noticed it in this job run: https://github.com/typesafegithub/github-workflows-kt/actions/runs/9101024130/job/25017188085
Likely caused by https://github.com/LeoColman/MyStack/commit/e22d71a3d984345fc84aca12bd9636777c839f38. Increasing the number of replicas introduced an inconsistency in how JARs are generated, likely in timestamps and/or file order.
@LeoColman no worries, this is not actionable for you, it's not a problem with your hosting directly 😊 It's just after increasing the number of instances revealed technically a bug...
Let me confirm my hypothesis regarding the root cause. Requesting a JAR two minutes apart from each other - the timestamps are different: ``` % zipinfo checkout-v4-23-14.jar Archive: checkout-v4-23-14.jar Zip...
After introducing determinstic entry order and resetting the timestamps: ``` % zipinfo checkout-v4-23-32.jar Archive: checkout-v4-23-32.jar Zip file size: 10134 bytes, number of entries: 5 -rw---- 2.0 fat 24 bX defN...
The bug should be gone, let's wait for several commits to confirm.
In progress in #1393 by @NikkyAI.
@NikkyAI I think it would be nice to add some minimal docs.
Yeah, something very simple with usage example would be good. We can add it later, after you play with it and it gets mature enough, up to you 😊