Garry Childs
Garry Childs
I noticed that a private property was being accessed in a child class [here]( https://github.com/ExpressionEngine/ExpressionEngine/blob/fe2e00c5ddfb1d2311e67faaa07c420c82ee2121/system/ee/ExpressionEngine/Controller/Channels/AbstractChannels.php#L134) and [here]( https://github.com/ExpressionEngine/ExpressionEngine/blob/fe2e00c5ddfb1d2311e67faaa07c420c82ee2121/system/ee/ExpressionEngine/Controller/Channels/AbstractChannels.php#L128), I have simply changed the properties visibility to protected.
Localize::string_to_timestamp() was returning an empty string rather than false when passed an empty string argument. When passing empty strings to Table::compareData() https://github.com/ExpressionEngine/ExpressionEngine/blob/ccbbf02bf9059a17cea5d994ac688022c94ced48/system/ee/ExpressionEngine/Library/CP/Table.php#L528C40-L528C40 they are treated as dates and compared as...
I was getting deprecation notices after updating a project to PHP 8.2. Have added type hints and property defaults along with a general code tidy on the worked files.