zf1-future icon indicating copy to clipboard operation
zf1-future copied to clipboard

Published 20 hours ago • verified publisher icon Shardj

Fix/remove PHP 8.2 depreciation messages

Open krytenuk opened this issue 1 year ago • 4 comments

I was getting deprecation notices after updating a project to PHP 8.2. Have added type hints and property defaults along with a general code tidy on the worked files.

krytenuk avatar Jan 02 '24 15:01 krytenuk

Type hints are breaking changes, not?

sreichel avatar Jan 21 '24 22:01 sreichel

As failing tests are suggesting, these are breaking changes, not really backward compatible. Therefore I'm against this PR to be merged.

develart-projects avatar Jan 23 '24 17:01 develart-projects

Changed the default delimiters to null. Hopefully fixed phpunit errors.

krytenuk avatar Feb 04 '24 19:02 krytenuk

Well, we still have tons of hints, forcing some type. Like: public function getViewScript(?string $action = null, ?bool $noController = null): string

Why exactly we are trying to be more typed here pls? Wgat are those deprecation messages about? By merging this, consequences could be huge in terms of backward compatibility.

develart-projects avatar Jul 22 '24 12:07 develart-projects