Krystian Panek

Results 94 comments of Krystian Panek

finally... are exclusions implemented correctly? I mean - https://github.com/mattn/go-zglob/pull/41#issuecomment-1368997118 - it is resolved or not...

task `packageDeploy` and `instanceDeploy` should be also aware of it

this approach looks quite hack'ish ;) I will consider that; thanks

@tomasz-niedzwiedz-wttech WDYT?

still using script may be easier for many APM users, I am very sure about it. and it will take many years on AEM that it will no longer support...

These scripts may have unlimited use cases. And the ease of creating it may be the killer feature and that's why I recommend to do this in that way. Imagine...

I just found that in the meantime that proxy was added and this is the most probably a root cause of my problem: https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/bundle/src/main/java/com/adobe/acs/commons/workflow/synthetic/impl/SyntheticWorkflowRunnerImpl.java#L321 https://github.com/Adobe-Consulting-Services/acs-aem-commons/compare/acs-aem-commons-4.5.2...acs-aem-commons-6.5.0#diff-46718450574c33fe39f448da9089a59110891ac7e2fcef2947a459e81e28bd93R321-R323 in PR/change https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/2734/files done by...

> a rule change that no longer allowed us to implement certain Java interfaces. this makes sense on CM but not on-prem. I fell like the way how the problem...

for whoever also struggling with this I created a patch for recovering working synthetic runner on AEM On-Prem. [synthetic-workflows-on-prem.patch](https://github.com/Adobe-Consulting-Services/acs-aem-commons/files/14994977/synthetic-workflows-on-prem.patch) just clone repo at tag 6.5.0 version/tag and apply the patch...

BTW some CSS on the BWM page seems to no longer work, just see this screenshot captured from pure AEM 6.5.19 + ACS Commons 6.5.0 ![image](https://github.com/Adobe-Consulting-Services/acs-aem-commons/assets/81212505/88348bfd-1914-4e0d-b83d-53b02ef03d16) I have a feeling...