Krystian Panek

Results 94 comments of Krystian Panek

this will make manual maven installation not required

GAP runtime should be touched not tooling around / GAP build.

once again similar error -

another error when doing deployment ``` [2022-06-02T13:59:44.696Z] Execution failed for task ':env:local:aem:instanceDeploy'. [2022-06-02T13:59:44.696Z] > Cannot read properties of node '/etc/packages/com.acme/acme-web-frontend-package-4.26.0-SNAPSHOT.zip/jcr:content/vlt:definition' on LocalInstance(name='dev-author', httpUrl='http://localhost:4502'). Cause: Failed request to GET http://localhost:4502/etc/packages/com.acme/acme-web-frontend-package-4.26.0-SNAPSHOT.zip/jcr:content/vlt:definition.json HTTP/1.1!...

both reading properties and checking existence could have retry mechanism to avoid such problems

https://github.com/wttech/gradle-aem-plugin/issues/834#issuecomment-1144957002 fixed by #905

initial issue seems to be fixed. instance deploy is now checking stability before. but node existence checking need to have retry mechanism for sure and that need to be improved.

https://github.com/wttech/gradle-aem-plugin/blob/5790cdf808e86ce81b3ce77a782e7a36b9db7d94/src/main/kotlin/com/cognifide/gradle/aem/common/instance/service/pkg/PackageManager.kt#L463 this line need to be protected with `retry` mechanism; this is caused because `deployAvoidance` feature which could be disabled to avoid the error for now

for the initial error, how about increasing default actionRetry from 1 to 3? https://github.com/wttech/gradle-aem-plugin/blob/5790cdf808e86ce81b3ce77a782e7a36b9db7d94/src/main/kotlin/com/cognifide/gradle/aem/common/instance/provision/step/AbstractStep.kt#L67

launcher could now use aem-ethos (docker image from aem sdk) as in GAT, @jean-khechfe-wttech could you update it?