go-zglob icon indicating copy to clipboard operation
go-zglob copied to clipboard

fastwalk function is slow because of walking the excluded directories

Open aminya opened this issue 2 years ago • 3 comments

The library still tries to read the excluded directory using the fastwalk function.

    sources:
      ["node_modules/**/*", "**/*.js"]

I have done some profiling on my fork of go-task, and here is the result. As you see, it reads the whole node_modules directory, which takes 70 seconds.

image

image

Mirrored from https://github.com/go-task/task/issues/225#issuecomment-1368764318

aminya avatar Jan 02 '23 09:01 aminya

I verified that #41 fixes the issue.

There was an unnecessary check that prevented the skipping.

aminya avatar Jan 02 '23 09:01 aminya

finally... are exclusions implemented correctly? I mean - https://github.com/mattn/go-zglob/pull/41#issuecomment-1368997118 - it is resolved or not...

krystian-panek-vmltech avatar Jun 14 '23 19:06 krystian-panek-vmltech

finally... are exclusions implemented correctly? I mean - https://github.com/mattn/go-zglob/pull/41#issuecomment-1368997118 - it is resolved or not...

This is not fixed yet

aminya avatar Aug 01 '23 19:08 aminya