go-zglob
go-zglob copied to clipboard
fastwalk function is slow because of walking the excluded directories
The library still tries to read the excluded directory using the fastwalk function.
sources:
["node_modules/**/*", "**/*.js"]
I have done some profiling on my fork of go-task, and here is the result. As you see, it reads the whole node_modules directory, which takes 70 seconds.


Mirrored from https://github.com/go-task/task/issues/225#issuecomment-1368764318
I verified that #41 fixes the issue.
There was an unnecessary check that prevented the skipping.
finally... are exclusions implemented correctly? I mean - https://github.com/mattn/go-zglob/pull/41#issuecomment-1368997118 - it is resolved or not...
finally... are exclusions implemented correctly? I mean - https://github.com/mattn/go-zglob/pull/41#issuecomment-1368997118 - it is resolved or not...
This is not fixed yet