Ryan Palmer

Results 5 comments of Ryan Palmer

@sheetalkamat I am experiencing an error with these changes in my project when using `getCombinedCodeFix`: ``` TypeError: Cannot read properties of undefined (reading 'push') at addLazyProgramDiagnosticExplainingFile (../../node_modules/.pnpm/@[email protected]/node_modules/@ts-morph/common/dist/typescript.js:126723:41) at checkSourceFilesBelongToPath (../../node_modules/.pnpm/@[email protected]/node_modules/@ts-morph/common/dist/typescript.js:126142:11)...

In [`codeFixProvider.ts#getDiagnostics`](https://github.com/microsoft/TypeScript/blob/9a23924d55367a3de89368f187318954fe40c439/src/services/codeFixProvider.ts#L127) I see we are getting semantic diagnostics before getting declaration diagnostics. As you can see in the stack traces above, the code path which sets `lazyProgramDiagnosticExplainingFile` to `undefined`...

Looks like some types actually are re-exported here: https://github.com/dsherret/ts-morph/blob/latest/packages/ts-morph/src/main.ts But `StandardizedFilePath` is not among them. Maybe this one is just missing.

> Hello I've ran into this as well. @kronodeus have you tried patching locally to see if that fixes the problem? Yes, monkey patching by re-exporting `StandardizedFilePath` fixed the issue...

Just wanted to chime in here: Our project relies on `#text` always being present. We ran into this same bug where `#text` is missing for self-closing elements that have attributes....