fast-xml-parser icon indicating copy to clipboard operation
fast-xml-parser copied to clipboard

Don't create text node for self closing tags when `alwaysCreateTextNode: true`

Open hornta opened this issue 11 months ago • 2 comments

Currently I can have the parser create a text node on tags without attributes by setting alwaysCreateTextNode: true. However, for self closing tags, I would like the parser to not create a text node. Right now it creates a text node set to an empty string.

I also noticed that if a self closing tags have any attributes, a text node is not created. It only seems like it's created when a self closing tags have no attributes.

// Given these settings:
const parser = new XMLParser({
	ignoreAttributes: false,
	allowBooleanAttributes: true,
	parseTagValue: false,
	alwaysCreateTextNode: true,
});

parser.parse("<workbookPr defaultThemeVersion="153222" />") 
// "workbookPr": {
//   "@_defaultThemeVersion": "153222"
// }

parser.parse("<workbookPr />") 
// "workbookPr": {
//   "#text": ""
// }

I expect that "#text" is always present, no matter if the self closing tag have attributes or not. But my primary expectation is to be able to have no text nodes at all for self closing tags while still allowing the parser to make text nodes for tags without any attributes.

hornta avatar Feb 13 '25 18:02 hornta

We're glad you find this project helpful. We'll try to address this issue ASAP. You can vist https://solothought.com to know recent features. Don't forget to star this repo.

github-actions[bot] avatar Feb 13 '25 18:02 github-actions[bot]

Just wanted to chime in here: Our project relies on #text always being present. We ran into this same bug where #text is missing for self-closing elements that have attributes. We're not asking for the same feature the OP is asking for, but would love for that bug to be fixed.

kronodeus avatar May 20 '25 15:05 kronodeus