Johannes Altmanninger

Results 734 comments of Johannes Altmanninger

This will be a nice feature though not easy to implement

we also need a way to tell fish not to escape those completions again (via something like `complete -c hyperfine -x --arguments-no-escape "__fish_complete_quoted_command"`). This quick attempt technically works but fails...

can you share commands to reproduce the two issues?

> I'm in favor of having a way to get the expanded tokens, but I'm not sure > > 1. this is correct in general for *all* uses of `commandline...

I prefer to break users here (short sharp shock) but it sounds like there's an objection so I'll add a separate flag?

Technically it's three but the current behavior should never be needed, I'd hide it from documentation, only mention it in the changelog. I don't know of a use case for...

both makes sense, thanks. So `commandline` flags `--expand-tokens` and `--raw-tokens` or `--tokens=expanded` and `--tokens=raw`. But if we do the latter `-x` should still be an abbreviation for `--tokens=expanded`

> Some way to control if a space suffix shall be added. A longstanding issue is that serialized completions don't carry metadata. I agree we should try to add them...

I think the only place where we have an inherent need for `set_errno` is `fish_signal_handler`. Everywhere else we should use wrappers that return `Result`. Preferrably we can use nix wrappers...

sorry I resubmitted my comment by accident