fish-shell icon indicating copy to clipboard operation
fish-shell copied to clipboard

Fix vi cursor for interactive and non-interactive read

Open bitraid opened this issue 1 year ago • 2 comments

Description

Fixes issue #10088

TODOs:

  • [ ] Changes to fish usage are reflected in user documentation/manpages.
  • [ ] Tests have been added for regressions fixed
  • [ ] User-visible changes noted in CHANGELOG.rst

bitraid avatar Nov 14 '23 17:11 bitraid

can you share commands to reproduce the two issues?

krobelus avatar Dec 30 '23 09:12 krobelus

can you share commands to reproduce the two issues?

Just run read (from both interactive and script) after setting fish_cursor_* in vi mode. For example (assuming default terminal cursor style is not line):

fish_vi_keybindings
set fish_cursor_insert line
read
fish -c read

For the first read, the cursor shape initially is not line (but changes once it switches out and then back to insert mode). For the second read (non interactive), the cursor shape doesn't change at all.

bitraid avatar Dec 30 '23 10:12 bitraid