Johannes Altmanninger

Results 734 comments of Johannes Altmanninger

I don't think this is blocked on Nix (or anything else), at least not for the 95% of cases where we only handle a set of concrete errors. The one...

Nice find, probably it's because `REPLACE_UNCLEAN = L"$*?({})";` is too crude. We should instead use something like `parse_util_locate_cmdsubst_range` to determine whether a string token contains command substitutions

I have repeatedly stumbled over the lack of heredocs; I think we should add them and perhaps a better quoting style as well.

> $(gcloud info --format="value(basic.python_location)") -m pip install We should probably support this. My one concern is that it kills the other possible meaning: ( foo; bar ) could be made...

how about ```fish functions -c fish_prompt default_fish_prompt function fish_prompt default_fish_prompt | string replace @ (set_color red)@ end ```

is there any theme that wants to this to be different than `$fish_color_normal`? If not then we can do ```diff diff --git a/share/functions/prompt_login.fish b/share/functions/prompt_login.fish index 632a462bd..3ec1647fd 100644 --- a/share/functions/prompt_login.fish +++...

I wonder when `date +%s` is actually too slow

> The downside of this change is that things like "$HOME" or "~" will no > longer be escaped. The API to avoid this downside while still fixing the issue...

I just use something like `tig origin/master@{1}..`