Results 1275 comments of Alon Zakai

@tlively Oh, right, thanks. That can't help here then. I guess in the long term if we add a way to mark a rec group as private then we could...

Wait, how does putting all the types in a single rec group work as a hack for a closed world validation issue?

> Is a bug in a feature that is a bug a feature? :rofl: Yeah, I guess that validation is kind of weird. Removing it as part of #6965 sgtm....

Sounds good, see #7019 for removing that validation.

@bashor One fix landed so far, another is open in https://github.com/WebAssembly/binaryen/pull/7018, and there is at least one more error after that lands that I haven't diagnosed yet. I can make...

With #7022, #7018, #7019 (all not yet landed), the testcase here finally passed in closed world (even including the extra validation checks of pass-debug mode). To get an idea of...

I also did an experiment where I * Moved the types of `_initialize` and `startUnitTests` out of the main rec group, and * Removed the exports of `main` and `__callFunction_(()->Unit)`...

@bashor Yes, it looks like `$main` was the actual problem. I removed all the type annotations from all exported functions earlier, but now I see that was more than was...

@osa1 > `[wasm-validator error in module]` .. Note that that wasm-opt validation error has been removed in https://github.com/WebAssembly/binaryen/pull/7019. After that, you can use any type on the boundary. However, types...

As this is a regression, bisecting may help find the exact commit where this regressed: https://emscripten.org/docs/contributing/developers_guide.html#bisecting It seems clear this is in LLVM, so actually bisecting directly there is also...