Results 1275 comments of Alon Zakai

I think fixing that issue helped a lot here: Now the main module has no passive segments. Eval-ctors can now see the absolute position of all segments, and so it...

Then we'd need to do something like that table management, to handle MAIN_MODULE. Though, that is a separate issue from pthreads, I think, which is the main topic here? So...

Those do appear to be missing implementations. Declarations were added in 0821cd10da but I guess those were forgotten. It would be good to add them now if someone has time.

These would be good to add, but note that we now have a StringLifting pass. One can emit imported strings, then lift them into the String* instructions, so it is...

As this sounds like a Safari-specific issue, it might help for more people affected by the issue to comment with details on the WebKit issue that's already been filed, that...

In general that means a type was not defined yet (not in a previous rec group, nor in the current one). But I can't tell from the screenshots why that...

Hmm, I can't seem to find anything wrong here. The code seems reasonable and what it is doing is basically ```wat (module (rec (type $struct (sub (struct (field (mut (ref...

Thanks @tlively ! I added a call to `dump()` in `binaryen-c.cpp`'s `TypeBuilderBuildAndDispose` method, right before the `build` command. It prints ```wat (type $0 (; temp ;) (sub (struct (field (mut...

Reduced testcase: ```wat (module (rec (type $parent (sub (struct (field (ref func))))) (type $child1 (sub $parent (struct (field (ref func))))) (type $child2 (sub $parent (struct (field (ref func))))) (type $func...

#7017 resolves one issue here, but I also see an error on SignaturePruning. @hondogo Separately from fixing these bugs, if you can avoid mixing the types of exported functions in...