Kevin Ring

Results 683 comments of Kevin Ring

I was initially going to say "but leap seconds!" Until I realized std::chrono even has some kind of support for leap seconds these days (C++20). Needs some investigation, but looks...

> I see those 4 tiles on screen, but when it's false, something else is dictating what to render... I think this is related to antimeridian wrapping. I'm not sure...

Here's the code that renders twice in 2D, with two different viewports: https://github.com/CesiumGS/cesium/blob/1.136/packages/engine/Source/Scene/Scene.js#L3283 Looks like it runs the tile selection algorithm twice, too. So that's why suspend update loses tiles;...

We have to be careful about licensing if we're grabbing files from the blueprintue.com web site. I can't find any clear statement of license with a quick look. It looks...

Thanks @timoore! While this looks reasonable to me, I'm a little hesitant to merge it at the moment. Mostly because I suspect we're eventually going to go in a direction...

> Persisting the login token might be risky if the user forgets to disconnect it after use. I don't think it's any riskier than holding any other login token in...

I believe I've addressed all the feedback. Rather than completely remove the ability to share and persist the token, I made these into configuration options. By default: 1. The login...

Hi @GhisBntly, can you set the SuspendUpdate property instead of hiding the tileset? Even if this works, you probably have a good point that a hidden tileset shouldn't update. I...

@j9liu I think this can be done without a change to cesium-native by waiting for the `Future` returned by `loadMetadata` to resolve before calling `updateViewGroup`. In most cases there's no...