Krati Ahuja

Results 16 comments of Krati Ahuja

@ryanto As discussed in https://github.com/ember-fastboot/ember-cli-fastboot/pull/454#issuecomment-317077365 , you can have fastboot-app-server run under https via defining a beforeMiddleware hook. As mentioned, I am not convinced that this needs to be a...

Could you please define what your usecase is to fork `fastboot`? Is there something missing that is better built within `fastboot`?

Thanks for the bug report! This seems like a bug to me in Ember/glimmer rather than fastboot. I'll dig into this coming week.

I thought mocha has the same behavior with returning promise or using `done`: https://mochajs.org/#working-with-promises Also not all tests are failing when using `done` in a `catch`.

There are two failing. One is a `jshint`.

No those are different issues. The new config was introduced later.

@krisselden are you suggesting do it once when the Node server comes up only? We currently do it once on startup and everytime some calls `reload`.

Aah no we don't do it for different sessions but when the Node process starts up and reload. I'll put a PR that splits this so reload is cheaper.

Yes, we would also need to make sure the [FastBoot result](https://github.com/ember-fastboot/fastboot/blob/master/src/result.js) is outside the sandbox so that we can serialize and send the template. But otherwise at high level it...

Ok, so I did a spike of the above proposed option. However, prototype extensions still don't work in one usecase: When I define something outside of the sandbox (example sandboxGlobals)...