fixed tests, now they are broken

[bekzod]

mocha has behavior of setting test as passing if promise returned inside it(....) passing, but if you have assertion in .catch it might skip assertion because returned promise resolved, to avoid that you need finish assertion with done

because of it I think some of errors have been missed in master @kratiahuja @krisselden

[kratiahuja]

I thought mocha has the same behavior with returning promise or using done: https://mochajs.org/#working-with-promises

Also not all tests are failing when using done in a catch.

[bekzod]

Yes of course, i wrote some therefore :P, I think only one failing other one i think just jshint error

On 4 Jun 2017, at 22:19, Krati Ahuja [email protected] wrote:

I thought mocha has the same behavior with returning promise or using done: https://mochajs.org/#working-with-promises

Also not all tests are failing when using done in a catch.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[kratiahuja]

There are two failing. One is a jshint.

[bekzod]

@kratiahuja I am look at those errors, will make PR if I fix them thanks

[bekzod]

hurray tests fixed 🎊

[bekzod]

good to merge ? :P

[bekzod]

this probably fixes https://github.com/ember-fastboot/ember-cli-fastboot/issues/209 too

[kratiahuja]

No those are different issues. The new config was introduced later.