Michał Krassowski

Results 1107 comments of Michał Krassowski

This an an excellent idea for an enhancement. How would you expect this to be invoked? Would it be a new argument to the `upset()` function? In the meantime a...

Maybe it could use a different name from `intersection_size` to distinguish function creating the subplot from `upset()` argument as it was done for `matrix`. So maybe just `size`? Or maybe...

You need to pass the plot to the `ggsave` function and then it works perfectly fine: ```R p = ( upset( movies, genres, name='genre', width_ratio=0.1, min_size=10, stripes=c(alpha('grey90', 0.45), alpha('white', 0.3)),...

You are correct, though it is not chopped off but just white text on a white background. You can change the colour and placement of the text - have a...

Thank you for highlighting this issue. Indeed, when adding the `mode` argument I also added code that overwrites the y axis label to make sure that users are aware of...

Good idea! I added `group_by` argument for feature parity. It is available in the v0.5.19 - you can update the package using: ``` devtools::install_github("krassowski/complex-upset") ``` Please see the example here:...

Not currently, but i will look into this.

FYI, the performance of `group_by` got a notable boost with e6814c160a5610a7aa02787141e52965f6f209bf and 866132729d6fbbe0a89f35a380d1af3f1a951b09 (version 0.7.4), roughly from 16.7 s to 1.7 s for ~1000 observations x 70 sets. Also, the...

This is intended, `intersection_size` takes in the `mode` argument as well. This allows you to have multiple modes displayed over a single intersection matrix. I also think that relevant examples...

Yes, it is already documented: ![Screenshot from 2021-03-02 10-20-04](https://user-images.githubusercontent.com/5832902/109634229-e7ae1100-7b40-11eb-9578-66c89a644700.png)